feat: deprecate new deployments #1934
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR updates the deprecation messaging for the shuttle.rs platform, focusing on two key changes:
- Modified
gateway/src/service.rsto update project creation deprecation message from "is deprecated" to "has been deprecated" as of December 19th, 2024 - Added deprecation handling in
gateway/src/api/latest.rsto block new deployments with a notice effective January 1st, 2024 - Maintains existing functionality while directing users to migrate to shuttle.dev platform
2 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
There was a problem hiding this comment.
PR Summary
(updates since last review)
This PR continues the deprecation of shuttle.rs by removing PostHog analytics integration and updating related infrastructure.
- Removed
async-posthogdependency and all PostHog client code fromgateway/Cargo.tomland related files - Simplified
override_create_serviceingateway/src/api/latest.rsby removing unused parameters and state - Removed PostHog client initialization and usage from
gateway/src/main.rsstart function
The changes focus on cleaning up analytics tracking while maintaining the core deprecation functionality previously implemented.
3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
jonaro00
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
As of the 1st of January 2025, making new deployments on the shuttle.rs platform has been deprecated, and users will be directed to upgrade to the shuttle.dev platform.
How has this been tested? (if applicable)
Will test in staging.